Closed Bug 1717728 Opened 4 years ago Closed 4 years ago

Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1052:21 in mozilla::ipc::MessageChannel::MaybeInterceptSpecialIOMessage(IPC::Message const&)

Categories

(Core :: IPC, defect)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- fixed
firefox92 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nika)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=343529618&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Pdos5y1SS7mFzN3HXATlgg/runs/0/artifacts/public/logs/live_backing.log


[task 2021-06-22T21:55:22.919Z] 21:55:22     INFO - TEST-START | /workers/Worker-terminate-forever.html
[task 2021-06-22T21:55:22.928Z] 21:55:22     INFO - Closing window f2819a46-b527-44c0-a8da-bd53d6ede3a3
[task 2021-06-22T21:55:24.144Z] 21:55:24     INFO - PID 10154 | ==================
[task 2021-06-22T21:55:24.145Z] 21:55:24     INFO - PID 10154 | WARNING: ThreadSanitizer: data race (pid=10154)
[task 2021-06-22T21:55:24.146Z] 21:55:24     INFO - PID 10154 |   Write of size 4 at 0x7b64002f35d0 by thread T4 (mutexes: write M862856163808594256):
[task 2021-06-22T21:55:24.148Z] 21:55:24     INFO - PID 10154 |     #0 mozilla::ipc::MessageChannel::MaybeInterceptSpecialIOMessage(IPC::Message const&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1052:21 (libxul.so+0x1590c87)
[task 2021-06-22T21:55:24.148Z] 21:55:24     INFO - PID 10154 |     #1 mozilla::ipc::MessageChannel::OnMessageReceivedFromLink(IPC::Message&&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1130:7 (libxul.so+0x15918f3)
[task 2021-06-22T21:55:24.149Z] 21:55:24     INFO - PID 10154 |     #2 mozilla::ipc::PortLink::OnPortStatusChanged() /builds/worker/checkouts/gecko/ipc/glue/MessageLink.cpp:199:12 (libxul.so+0x159b660)
[task 2021-06-22T21:55:24.150Z] 21:55:24     INFO - PID 10154 |     #3 mozilla::ipc::PortLink::PortObserverThunk::OnPortStatusChanged() /builds/worker/checkouts/gecko/ipc/glue/MessageLink.cpp:60:14 (libxul.so+0x15a933f)
[task 2021-06-22T21:55:24.151Z] 21:55:24     INFO - PID 10154 |     #4 mozilla::ipc::NodeController::PortStatusChanged(mojo::core::ports::PortRef const&) /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:347:49 (libxul.so+0x15a0f86)
[task 2021-06-22T21:55:24.151Z] 21:55:24     INFO - PID 10154 |     #5 mojo::core::ports::Node::OnUserMessage(mozilla::UniquePtr<mojo::core::ports::UserMessageEvent, mozilla::DefaultDelete<mojo::core::ports::UserMessageEvent> >) /builds/worker/checkouts/gecko/ipc/chromium/src/mojo/core/ports/node.cc:574:16 (libxul.so+0x153783f)
[task 2021-06-22T21:55:24.152Z] 21:55:24     INFO - PID 10154 |     #6 mojo::core::ports::Node::AcceptEvent(mozilla::UniquePtr<mojo::core::ports::Event, mozilla::DefaultDelete<mojo::core::ports::Event> >) /builds/worker/checkouts/gecko/ipc/chromium/src/mojo/core/ports/node.cc:409:14 (libxul.so+0x1536ffe)
[task 2021-06-22T21:55:24.153Z] 21:55:24     INFO - PID 10154 |     #7 mozilla::ipc::NodeController::OnEventMessage(mojo::core::ports::NodeName const&, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >) /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:402:16 (libxul.so+0x15a14f4)
[task 2021-06-22T21:55:24.153Z] 21:55:24     INFO - PID 10154 |     #8 non-virtual thunk to mozilla::ipc::NodeController::OnEventMessage(mojo::core::ports::NodeName const&, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >) /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp (libxul.so+0x15a1789)
[task 2021-06-22T21:55:24.154Z] 21:55:24     INFO - PID 10154 |     #9 mozilla::ipc::NodeChannel::OnMessageReceived(IPC::Message&&) /builds/worker/checkouts/gecko/ipc/glue/NodeChannel.cpp:260:18 (libxul.so+0x159e0c7)
[task 2021-06-22T21:55:24.155Z] 21:55:24     INFO - PID 10154 |     #10 IPC::Channel::ChannelImpl::ProcessIncomingMessages() /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:553:20 (libxul.so+0x152b97b)
[task 2021-06-22T21:55:24.155Z] 21:55:24     INFO - PID 10154 |     #11 IPC::Channel::ChannelImpl::OnFileCanReadWithoutBlocking(int) /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:822:10 (libxul.so+0x152c51f)
[task 2021-06-22T21:55:24.156Z] 21:55:24     INFO - PID 10154 |     #12 base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_pump_libevent.cc:249:14 (libxul.so+0x1518894)
[task 2021-06-22T21:55:24.157Z] 21:55:24     INFO - PID 10154 |     #13 event_persist_closure /builds/worker/checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:1580:9 (libxul.so+0x154d15b)
[task 2021-06-22T21:55:24.157Z] 21:55:24     INFO - PID 10154 |     #14 event_process_active_single_queue /builds/worker/checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:1639:4 (libxul.so+0x154d15b)
[task 2021-06-22T21:55:24.158Z] 21:55:24     INFO - PID 10154 |     #15 event_process_active /builds/worker/checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c (libxul.so+0x154915b)
[task 2021-06-22T21:55:24.159Z] 21:55:24     INFO - PID 10154 |     #16 event_base_loop /builds/worker/checkouts/gecko/ipc/chromium/src/third_party/libevent/event.c:1961:12 (libxul.so+0x154915b)
[task 2021-06-22T21:55:24.159Z] 21:55:24     INFO - PID 10154 |     #17 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_pump_libevent.cc (libxul.so+0x1518e71)
[task 2021-06-22T21:55:24.160Z] 21:55:24     INFO - PID 10154 |     #18 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:331:10 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.160Z] 21:55:24     INFO - PID 10154 |     #19 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:324:3 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.161Z] 21:55:24     INFO - PID 10154 |     #20 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:306:3 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.162Z] 21:55:24     INFO - PID 10154 |     #21 base::Thread::ThreadMain() /builds/worker/checkouts/gecko/ipc/chromium/src/base/thread.cc:187:16 (libxul.so+0x15270d6)
[task 2021-06-22T21:55:24.162Z] 21:55:24     INFO - PID 10154 |     #22 ThreadFunc(void*) /builds/worker/checkouts/gecko/ipc/chromium/src/base/platform_thread_posix.cc:40:13 (libxul.so+0x152081e)
[task 2021-06-22T21:55:24.163Z] 21:55:24     INFO - PID 10154 |   Previous write of size 4 at 0x7b64002f35d0 by thread T22:
[task 2021-06-22T21:55:24.164Z] 21:55:24     INFO - PID 10154 |     #0 mozilla::ipc::PortLink::PortLink(mozilla::ipc::MessageChannel*, mozilla::ipc::ScopedPort) /builds/worker/checkouts/gecko/ipc/glue/MessageLink.cpp:79:24 (libxul.so+0x159a925)
[task 2021-06-22T21:55:24.164Z] 21:55:24     INFO - PID 10154 |     #1 MakeUnique<mozilla::ipc::PortLink, mozilla::ipc::MessageChannel *, mozilla::ipc::ScopedPort> /builds/worker/workspace/obj-build/dist/include/mozilla/UniquePtr.h:609:27 (libxul.so+0x158e8ed)
[task 2021-06-22T21:55:24.165Z] 21:55:24     INFO - PID 10154 |     #2 mozilla::ipc::MessageChannel::Open(mozilla::ipc::ScopedPort, mozilla::ipc::Side, nsISerialEventTarget*) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:806:11 (libxul.so+0x158e8ed)
[task 2021-06-22T21:55:24.166Z] 21:55:24     INFO - PID 10154 |     #3 mozilla::ipc::IToplevelProtocol::Open(mozilla::ipc::ScopedPort, int) /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:644:27 (libxul.so+0x15b742b)
[task 2021-06-22T21:55:24.166Z] 21:55:24     INFO - PID 10154 |     #4 mozilla::ipc::Endpoint<mozilla::ipc::PBackgroundParent>::Bind(mozilla::ipc::PBackgroundParent*) /builds/worker/workspace/obj-build/dist/include/mozilla/ipc/Endpoint.h:81:20 (libxul.so+0x1575524)
[task 2021-06-22T21:55:24.167Z] 21:55:24     INFO - PID 10154 |     #5 operator() /builds/worker/checkouts/gecko/ipc/glue/BackgroundImpl.cpp:1115:7 (libxul.so+0x15750f7)
[task 2021-06-22T21:55:24.168Z] 21:55:24     INFO - PID 10154 |     #6 mozilla::detail::RunnableFunction<(anonymous namespace)::ParentImpl::Alloc(mozilla::dom::ContentParent*, mozilla::ipc::Endpoint<mozilla::ipc::PBackgroundParent>&&)::$_14>::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:534:5 (libxul.so+0x15750f7)
[task 2021-06-22T21:55:24.168Z] 21:55:24     INFO - PID 10154 |     #7 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1146:16 (libxul.so+0xc92e2f)
[task 2021-06-22T21:55:24.169Z] 21:55:24     INFO - PID 10154 |     #8 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xc99ab2)
[task 2021-06-22T21:55:24.169Z] 21:55:24     INFO - PID 10154 |     #9 mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:330:5 (libxul.so+0x159cbb8)
[task 2021-06-22T21:55:24.170Z] 21:55:24     INFO - PID 10154 |     #10 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:331:10 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.171Z] 21:55:24     INFO - PID 10154 |     #11 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:324:3 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.171Z] 21:55:24     INFO - PID 10154 |     #12 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:306:3 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.172Z] 21:55:24     INFO - PID 10154 |     #13 nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:392:10 (libxul.so+0xc8f4d8)
[task 2021-06-22T21:55:24.173Z] 21:55:24     INFO - PID 10154 |     #14 _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5 (libnspr4.so+0x44cd6)
[task 2021-06-22T21:55:24.173Z] 21:55:24     INFO - PID 10154 |   Location is heap block of size 1088 at 0x7b64002f3500 allocated by main thread:
[task 2021-06-22T21:55:24.174Z] 21:55:24     INFO - PID 10154 |     #0 malloc /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:651:5 (firefox+0x55fbb)
[task 2021-06-22T21:55:24.174Z] 21:55:24     INFO - PID 10154 |     #1 moz_xmalloc /builds/worker/checkouts/gecko/memory/mozalloc/mozalloc.cpp:52:15 (firefox+0xcc7eb)
[task 2021-06-22T21:55:24.175Z] 21:55:24     INFO - PID 10154 |     #2 operator new /builds/worker/workspace/obj-build/dist/include/mozilla/cxxalloc.h:33:10 (libxul.so+0x15576b1)
[task 2021-06-22T21:55:24.176Z] 21:55:24     INFO - PID 10154 |     #3 Alloc /builds/worker/checkouts/gecko/ipc/glue/BackgroundImpl.cpp:1113:30 (libxul.so+0x15576b1)
[task 2021-06-22T21:55:24.176Z] 21:55:24     INFO - PID 10154 |     #4 mozilla::ipc::BackgroundParent::Alloc(mozilla::dom::ContentParent*, mozilla::ipc::Endpoint<mozilla::ipc::PBackgroundParent>&&) /builds/worker/checkouts/gecko/ipc/glue/BackgroundImpl.cpp:691:10 (libxul.so+0x15576b1)
[task 2021-06-22T21:55:24.177Z] 21:55:24     INFO - PID 10154 |     #5 mozilla::dom::ContentParent::RecvInitBackground(mozilla::ipc::Endpoint<mozilla::ipc::PBackgroundParent>&&) /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3730:8 (libxul.so+0x4827731)
[task 2021-06-22T21:55:24.178Z] 21:55:24     INFO - PID 10154 |     #6 mozilla::dom::PContentParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PContentParent.cpp:7974:57 (libxul.so+0x1708109)
[task 2021-06-22T21:55:24.178Z] 21:55:24     INFO - PID 10154 |     #7 mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:2085:25 (libxul.so+0x1598051)
[task 2021-06-22T21:55:24.179Z] 21:55:24     INFO - PID 10154 |     #8 mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:2012:9 (libxul.so+0x15965b5)
[task 2021-06-22T21:55:24.180Z] 21:55:24     INFO - PID 10154 |     #9 mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1860:3 (libxul.so+0x15971ba)
[task 2021-06-22T21:55:24.180Z] 21:55:24     INFO - PID 10154 |     #10 mozilla::ipc::MessageChannel::MessageTask::Run() /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1891:13 (libxul.so+0x15977c1)
[task 2021-06-22T21:55:24.181Z] 21:55:24     INFO - PID 10154 |     #11 mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:502:16 (libxul.so+0xca4f87)
[task 2021-06-22T21:55:24.181Z] 21:55:24     INFO - PID 10154 |     #12 mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:805:26 (libxul.so+0xc81fea)
[task 2021-06-22T21:55:24.182Z] 21:55:24     INFO - PID 10154 |     #13 mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:641:15 (libxul.so+0xc80646)
[task 2021-06-22T21:55:24.182Z] 21:55:24     INFO - PID 10154 |     #14 mozilla::TaskController::ProcessPendingMTTask(bool) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:425:36 (libxul.so+0xc80914)
[task 2021-06-22T21:55:24.183Z] 21:55:24     INFO - PID 10154 |     #15 operator() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:138:37 (libxul.so+0xca8eda)
[task 2021-06-22T21:55:24.183Z] 21:55:24     INFO - PID 10154 |     #16 mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_1>::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:534:5 (libxul.so+0xca8eda)
[task 2021-06-22T21:55:24.184Z] 21:55:24     INFO - PID 10154 |     #17 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1152:16 (libxul.so+0xc92b50)
[task 2021-06-22T21:55:24.184Z] 21:55:24     INFO - PID 10154 |     #18 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xc99ab2)
[task 2021-06-22T21:55:24.185Z] 21:55:24     INFO - PID 10154 |     #19 mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:107:5 (libxul.so+0x159c030)
[task 2021-06-22T21:55:24.185Z] 21:55:24     INFO - PID 10154 |     #20 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:331:10 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.187Z] 21:55:24     INFO - PID 10154 |     #21 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:324:3 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.187Z] 21:55:24     INFO - PID 10154 |     #22 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:306:3 (libxul.so+0x15159dc)
[task 2021-06-22T21:55:24.187Z] 21:55:24     INFO - PID 10154 |     #23 nsBaseAppShell::Run() /builds/worker/checkouts/gecko/widget/nsBaseAppShell.cpp:137:27 (libxul.so+0x4c90806)
[task 2021-06-22T21:55:24.187Z] 21:55:24     INFO - PID 10154 |     #24 nsAppStartup::Run() /builds/worker/checkouts/gecko/toolkit/components/startup/nsAppStartup.cpp:273:30 (libxul.so+0x69e7158)
[task 2021-06-22T21:55:24.188Z] 21:55:24     INFO - PID 10154 |     #25 XREMain::XRE_mainRun() /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5247:22 (libxul.so+0x6b02e3a)
[task 2021-06-22T21:55:24.188Z] 21:55:24     INFO - PID 10154 |     #26 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5445:8 (libxul.so+0x6b03b87)
[task 2021-06-22T21:55:24.189Z] 21:55:24     INFO - PID 10154 |     #27 XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5504:21 (libxul.so+0x6b04124)
[task 2021-06-22T21:55:24.189Z] 21:55:24     INFO - PID 10154 |     #28 mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:45:12 (libxul.so+0x6b0e6c2)
[task 2021-06-22T21:55:24.190Z] 21:55:24     INFO - PID 10154 |     #29 do_main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:225:22 (firefox+0xca6e0)
[task 2021-06-22T21:55:24.190Z] 21:55:24     INFO - PID 10154 |     #30 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:378:16 (firefox+0xca6e0)
[task 2021-06-22T21:55:24.190Z] 21:55:24     INFO - PID 10154 |   Mutex M862856163808594256 is already destroyed.
[task 2021-06-22T21:55:24.191Z] 21:55:24     INFO - PID 10154 |   Thread T4 'IPC I/O Parent' (tid=10165, running) created by main thread at:
[task 2021-06-22T21:55:24.191Z] 21:55:24     INFO - PID 10154 |     #0 pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:965:3 (firefox+0x577eb)
[task 2021-06-22T21:55:24.192Z] 21:55:24     INFO - PID 10154 |     #1 CreateThread /builds/worker/checkouts/gecko/ipc/chromium/src/base/platform_thread_posix.cc:123:14 (libxul.so+0x151d787)
[task 2021-06-22T21:55:24.192Z] 21:55:24     INFO - PID 10154 |     #2 PlatformThread::Create(unsigned long, PlatformThread::Delegate*, unsigned long*) /builds/worker/checkouts/gecko/ipc/chromium/src/base/platform_thread_posix.cc:134:10 (libxul.so+0x151d787)
[task 2021-06-22T21:55:24.193Z] 21:55:24     INFO - PID 10154 |     #3 base::Thread::StartWithOptions(base::Thread::Options const&) /builds/worker/checkouts/gecko/ipc/chromium/src/base/thread.cc:93:8 (libxul.so+0x1526c91)
[task 2021-06-22T21:55:24.193Z] 21:55:24     INFO - PID 10154 |     #4 NS_InitXPCOM /builds/worker/checkouts/gecko/xpcom/build/XPCOMInit.cpp:318:9 (libxul.so+0xcd088c)
[task 2021-06-22T21:55:24.194Z] 21:55:24     INFO - PID 10154 |     #5 ScopedXPCOMStartup::Initialize(bool) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:1714:8 (libxul.so+0x6af8c9d)
[task 2021-06-22T21:55:24.194Z] 21:55:24     INFO - PID 10154 |     #6 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5441:22 (libxul.so+0x6b03b71)
[task 2021-06-22T21:55:24.194Z] 21:55:24     INFO - PID 10154 |     #7 XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5504:21 (libxul.so+0x6b04124)
[task 2021-06-22T21:55:24.195Z] 21:55:24     INFO - PID 10154 |     #8 mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:45:12 (libxul.so+0x6b0e6c2)
[task 2021-06-22T21:55:24.195Z] 21:55:24     INFO - PID 10154 |     #9 do_main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:225:22 (firefox+0xca6e0)
[task 2021-06-22T21:55:24.196Z] 21:55:24     INFO - PID 10154 |     #10 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:378:16 (firefox+0xca6e0)
[task 2021-06-22T21:55:24.196Z] 21:55:24     INFO - PID 10154 |   Thread T22 'IPDL Background' (tid=10222, running) created by main thread at:
[task 2021-06-22T21:55:24.197Z] 21:55:24     INFO - PID 10154 |     #0 pthread_create /builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:965:3 (firefox+0x577eb)
[task 2021-06-22T21:55:24.197Z] 21:55:24     INFO - PID 10154 |     #1 _PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:458:14 (libnspr4.so+0x3be33)
[task 2021-06-22T21:55:24.198Z] 21:55:24     INFO - PID 10154 |     #2 PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:533:12 (libnspr4.so+0x30915)
[task 2021-06-22T21:55:24.198Z] 21:55:24     INFO - PID 10154 |     #3 nsThread::Init(nsTSubstring<char> const&) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:606:18 (libxul.so+0xc90842)
[task 2021-06-22T21:55:24.199Z] 21:55:24     INFO - PID 10154 |     #4 nsThreadManager::NewNamedThread(nsTSubstring<char> const&, unsigned int, nsIThread**) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:574:12 (libxul.so+0xc9893a)
[task 2021-06-22T21:55:24.199Z] 21:55:24     INFO - PID 10154 |     #5 NS_NewNamedThread(nsTSubstring<char> const&, nsIThread**, already_AddRefed<nsIRunnable>, unsigned int) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:169:57 (libxul.so+0xca0804)
[task 2021-06-22T21:55:24.199Z] 21:55:24     INFO - PID 10154 |     #6 NS_NewNamedThread<16> /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:74:10 (libxul.so+0x156cf07)
[task 2021-06-22T21:55:24.200Z] 21:55:24     INFO - PID 10154 |     #7 (anonymous namespace)::ParentImpl::CreateBackgroundThread() /builds/worker/checkouts/gecko/ipc/glue/BackgroundImpl.cpp:1241:7 (libxul.so+0x156cf07)
[task 2021-06-22T21:55:24.200Z] 21:55:24     INFO - PID 10154 |     #8 RunOnMainThread /builds/worker/checkouts/gecko/ipc/glue/BackgroundImpl.cpp:1451:30 (libxul.so+0x156f9cc)
[task 2021-06-22T21:55:24.201Z] 21:55:24     INFO - PID 10154 |     #9 (anonymous namespace)::ParentImpl::CreateActorHelper::Run() /builds/worker/checkouts/gecko/ipc/glue/BackgroundImpl.cpp:1470:17 (libxul.so+0x156f9cc)
[task 2021-06-22T21:55:24.201Z] 21:55:24     INFO - PID 10154 |     #10 mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:502:16 (libxul.so+0xca4f87)
[task 2021-06-22T21:55:24.202Z] 21:55:24     INFO - PID 10154 |     #11 mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:805:26 (libxul.so+0xc81fea)
[task 2021-06-22T21:55:24.202Z] 21:55:24     INFO - PID 10154 |     #12 mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:641:15 (libxul.so+0xc80646)
[task 2021-06-22T21:55:24.203Z] 21:55:24     INFO - PID 10154 |     #13 mozilla::TaskController::ProcessPendingMTTask(bool) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:425:36 (libxul.so+0xc80914)
[task 2021-06-22T21:55:24.203Z] 21:55:24     INFO - PID 10154 |     #14 operator() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:138:37 (libxul.so+0xca8eda)
[task 2021-06-22T21:55:24.204Z] 21:55:24     INFO - PID 10154 |     #15 mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_1>::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:534:5 (libxul.so+0xca8eda)
[task 2021-06-22T21:55:24.204Z] 21:55:24     INFO - PID 10154 |     #16 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1152:16 (libxul.so+0xc92b50)
[task 2021-06-22T21:55:24.205Z] 21:55:24     INFO - PID 10154 |     #17 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:548:10 (libxul.so+0xc99ab2)
[task 2021-06-22T21:55:24.205Z] 21:55:24     INFO - PID 10154 |     #18 SpinEventLoopUntil<mozilla::ProcessFailureBehavior::ReportToCaller, (lambda at /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:714:36)> /builds/worker/workspace/obj-build/dist/include/mozilla/SpinEventLoopUntil.h:93:25 (libxul.so+0xc99442)
[task 2021-06-22T21:55:24.206Z] 21:55:24     INFO - PID 10154 |     #19 nsThreadManager::SpinEventLoopUntilInternal(nsTSubstring<char> const&, nsINestedEventLoopCondition*, mozilla::ShutdownPhase) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:714:8 (libxul.so+0xc99442)
[task 2021-06-22T21:55:24.206Z] 21:55:24     INFO - PID 10154 |     #20 nsThreadManager::SpinEventLoopUntil(nsTSubstring<char> const&, nsINestedEventLoopCondition*) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:640:10 (libxul.so+0xc98f93)
[task 2021-06-22T21:55:24.207Z] 21:55:24     INFO - PID 10154 |     #21 NS_InvokeByIndex /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:101 (libxul.so+0xcbee65)
[task 2021-06-22T21:55:24.207Z] 21:55:24     INFO - PID 10154 |     #22 XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:922:10 (libxul.so+0x1ba5480)
[task 2021-06-22T21:55:24.208Z] 21:55:24     INFO - PID 10154 |     #23 CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:426:13 (libxul.so+0x6c3c494)
[task 2021-06-22T21:55:24.208Z] 21:55:24     INFO - PID 10154 |     #24 js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:511:12 (libxul.so+0x6c3c494)
[task 2021-06-22T21:55:24.209Z] 21:55:24     INFO - PID 10154 |     #25 InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:571:10 (libxul.so+0x6c320c9)
[task 2021-06-22T21:55:24.209Z] 21:55:24     INFO - PID 10154 |     #26 CallFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:575:10 (libxul.so+0x6c320c9)
[task 2021-06-22T21:55:24.209Z] 21:55:24     INFO - PID 10154 |     #27 Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3226:16 (libxul.so+0x6c320c9)
[task 2021-06-22T21:55:24.210Z] 21:55:24     INFO - PID 10154 |     #28 js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:395:13 (libxul.so+0x6c258cc)
[task 2021-06-22T21:55:24.210Z] 21:55:24     INFO - PID 10154 |     #29 js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:543:13 (libxul.so+0x6c3ccf1)
[task 2021-06-22T21:55:24.211Z] 21:55:24     INFO - PID 10154 |     #30 InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:571:10 (libxul.so+0x6c3d5cf)
[task 2021-06-22T21:55:24.211Z] 21:55:24     INFO - PID 10154 |     #31 js::CallFromStack(JSContext*, JS::CallArgs const&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:575:10 (libxul.so+0x6c3d5cf)
[task 2021-06-22T21:55:24.212Z] 21:55:24     INFO - PID 10154 |     #32 js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jit/BaselineIC.cpp:1595:10 (libxul.so+0x742c8d2)
[task 2021-06-22T21:55:24.212Z] 21:55:24     INFO - PID 10154 |     #33 <null> <null> (0x7f556afa4d88)
[task 2021-06-22T21:55:24.213Z] 21:55:24     INFO - PID 10154 |     #34 Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:2158:17 (libxul.so+0x6c26a08)
[task 2021-06-22T21:55:24.213Z] 21:55:24     INFO - PID 10154 |     #35 js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:395:13 (libxul.so+0x6c258cc)
[task 2021-06-22T21:55:24.214Z] 21:55:24     INFO - PID 10154 |     #36 js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:543:13 (libxul.so+0x6c3ccf1)
[task 2021-06-22T21:55:24.214Z] 21:55:24     INFO - PID 10154 |     #37 InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:571:10 (libxul.so+0x6c3d783)
[task 2021-06-22T21:55:24.215Z] 21:55:24     INFO - PID 10154 |     #38 js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:588:8 (libxul.so+0x6c3d783)
[task 2021-06-22T21:55:24.215Z] 21:55:24     INFO - PID 10154 |     #39 js::fun_apply(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/src/vm/JSFunction.cpp:1150:10 (libxul.so+0x6e78e85)
[task 2021-06-22T21:55:24.215Z] 21:55:24     INFO - PID 10154 |     #40 CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:426:13 (libxul.so+0x6c3c494)
[task 2021-06-22T21:55:24.216Z] 21:55:24     INFO - PID 10154 |     #41 js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:511:12 (libxul.so+0x6c3c494)
[task 2021-06-22T21:55:24.216Z] 21:55:24     INFO - PID 10154 |     #42 InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:571:10 (libxul.so+0x6c320c9)
[task 2021-06-22T21:55:24.217Z] 21:55:24     INFO - PID 10154 |     #43 CallFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:575:10 (libxul.so+0x6c320c9)
[task 2021-06-22T21:55:24.217Z] 21:55:24     INFO - PID 10154 |     #44 Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3226:16 (libxul.so+0x6c320c9)
[task 2021-06-22T21:55:24.218Z] 21:55:24     INFO - PID 10154 |     #45 js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:395:13 (libxul.so+0x6c258cc)
[task 2021-06-22T21:55:24.218Z] 21:55:24     INFO - PID 10154 |     #46 js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:543:13 (libxul.so+0x6c3ccf1)
[task 2021-06-22T21:55:24.219Z] 21:55:24     INFO - PID 10154 |     #47 InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:571:10 (libxul.so+0x6c3d783)
[task 2021-06-22T21:55:24.219Z] 21:55:24     INFO - PID 10154 |     #48 js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:588:8 (libxul.so+0x6c3d783)
[task 2021-06-22T21:55:24.220Z] 21:55:24     INFO - PID 10154 |     #49 JS_CallFunctionValue(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jsapi.cpp:2722:10 (libxul.so+0x70e7fc9)
[task 2021-06-22T21:55:24.220Z] 21:55:24     INFO - PID 10154 |     #50 nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedJSClass.cpp:971:17 (libxul.so+0x1b9c5d9)
[task 2021-06-22T21:55:24.221Z] 21:55:24     INFO - PID 10154 |     #51 PrepareAndDispatch /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:115:37 (libxul.so+0xcbfe41)
[task 2021-06-22T21:55:24.221Z] 21:55:24     INFO - PID 10154 |     #52 SharedStub <null> (libxul.so+0xcbf1a2)
[task 2021-06-22T21:55:24.222Z] 21:55:24     INFO - PID 10154 |     #53 XREMain::XRE_mainRun() /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:4996:18 (libxul.so+0x6b0281f)
[task 2021-06-22T21:55:24.222Z] 21:55:24     INFO - PID 10154 |     #54 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5445:8 (libxul.so+0x6b03b87)
[task 2021-06-22T21:55:24.223Z] 21:55:24     INFO - PID 10154 |     #55 XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:5504:21 (libxul.so+0x6b04124)
[task 2021-06-22T21:55:24.223Z] 21:55:24     INFO - PID 10154 |     #56 mozilla::BootstrapImpl::XRE_main(int, char**, mozilla::BootstrapConfig const&) /builds/worker/checkouts/gecko/toolkit/xre/Bootstrap.cpp:45:12 (libxul.so+0x6b0e6c2)
[task 2021-06-22T21:55:24.223Z] 21:55:24     INFO - PID 10154 |     #57 do_main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:225:22 (firefox+0xca6e0)
[task 2021-06-22T21:55:24.224Z] 21:55:24     INFO - PID 10154 |     #58 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:378:16 (firefox+0xca6e0)
[task 2021-06-22T21:55:24.231Z] 21:55:24     INFO - PID 10154 | SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1052:21 in mozilla::ipc::MessageChannel::MaybeInterceptSpecialIOMessage(IPC::Message const&)
[task 2021-06-22T21:55:24.232Z] 21:55:24     INFO - PID 10154 | ==================
[task 2021-06-22T21:55:24.234Z] 21:55:24     INFO - IOError on command, setting status to CRASH
[task 2021-06-22T21:55:24.236Z] 21:55:24     INFO - PID 10154 | Exiting due to channel error.
[task 2021-06-22T21:55:24.237Z] 21:55:24     INFO - TEST-UNEXPECTED-CRASH | /workers/Worker-terminate-forever.html | expected OK
[task 2021-06-22T21:55:24.237Z] 21:55:24     INFO - TEST-INFO took 1313ms
[task 2021-06-22T21:55:24.246Z] 21:55:24     INFO - PID 10154 | Exiting due to channel error.
[task 2021-06-22T21:55:24.247Z] 21:55:24     INFO - PID 10154 | Exiting due to channel error.
[task 2021-06-22T21:55:24.249Z] 21:55:24     INFO - PID 10154 | Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=89.2786) Exiting due to channel error.
[task 2021-06-22T21:55:25.280Z] 21:55:25     INFO - PID 10154 | Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=87.9538) Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=43.727)
[task 2021-06-22T21:55:25.281Z] 21:55:25     INFO - Browser exited with return code -6
[task 2021-06-22T21:55:25.283Z] 21:55:25     INFO - Closing logging queue
[task 2021-06-22T21:55:25.283Z] 21:55:25     INFO - queue closed
[task 2021-06-22T21:55:25.305Z] 21:55:25     INFO - INFO | runtests.py | TSan using symbolizer at /builds/worker/workspace/build/application/firefox/llvm-symbolizer
[task 2021-06-22T21:55:25.305Z] 21:55:25     INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmpcym28c_e
[task 2021-06-22T21:55:25.318Z] 21:55:25     INFO - PID 10356 | 1624398848048	Marionette	INFO	Marionette enabled
[task 2021-06-22T21:55:25.318Z] 21:55:25     INFO - PID 10356 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at /tmp/tmp539sq6y_/search.json.mozlz4", (void 0)))
[task 2021-06-22T21:55:25.319Z] 21:55:25     INFO - PID 10356 | 1624398869928	Marionette	INFO	Listening on port 48452
[task 2021-06-22T21:55:25.319Z] 21:55:25     INFO - Starting runner
[task 2021-06-22T21:55:27.373Z] 21:55:27     INFO - TEST-START | /workers/Worker-termination-with-port-messages.html

possible regression from your big stack of IPC patches?

Flags: needinfo?(nika)

Yup, this is definitely a regression from that stack of patches. I incorrectly assign to mChan->mChannelState after the call to mNode->SetPortObserver, which would mean that the IO thread could race and start accessing the channel through the port observer before the mChan->mChannelState update happens, leading to a data race. I think this should be fixed by flipping those two lines around.

EDIT: Actually this is probably better handled by delaying setting the port observer to happen async to avoid any other potential races e.g. due to the mSide and mLink fields not being initialized yet.

Assignee: nobody → nika
Flags: needinfo?(nika)
Blocks: tsan
Regressed by: 1713148
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1713148

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1508404d1ef0 Hold MessageChannel's monitor when creating PortLink, r=handyman
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

The patch landed in nightly and beta is affected.
:nika, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nika)

Comment on attachment 9228469 [details]
Bug 1717728 - Hold MessageChannel's monitor when creating PortLink,

Beta/Release Uplift Approval Request

  • User impact if declined: potential low-impact data race
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): fairly small change
  • String changes made/needed: none
Flags: needinfo?(nika)
Attachment #9228469 - Flags: approval-mozilla-beta?

Comment on attachment 9228469 [details]
Bug 1717728 - Hold MessageChannel's monitor when creating PortLink,

Low risk in early betas, approved for uplift in 91 beta 4, thanks.

Attachment #9228469 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: